Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table customize filter update #21218

Merged
merged 2 commits into from
Feb 4, 2020
Merged

fix: Table customize filter update #21218

merged 2 commits into from
Feb 4, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 4, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21204

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table customize filter can not typing bug.
🇨🇳 Chinese 修复 Table 自定义过滤无法输入的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 4, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 40d96f9:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

afc163 commented Feb 4, 2020

/rebase

1 similar comment
@zombieJ
Copy link
Member Author

zombieJ commented Feb 4, 2020

/rebase

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #21218 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21218   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         296      296           
  Lines        6918     6918           
  Branches     1921     1909   -12     
=======================================
  Hits         6745     6745           
  Misses        173      173
Impacted Files Coverage Δ
components/table/hooks/useSyncState.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b7576...40d96f9. Read the comment docs.

@zombieJ zombieJ merged commit 6d685c7 into master Feb 4, 2020
@zombieJ zombieJ deleted the fix-table-update branch February 4, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table filter dropdown does not update state
3 participants