Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): label width not correct when screen less than xs #21222

Merged
merged 3 commits into from Feb 12, 2020
Merged

fix(Form): label width not correct when screen less than xs #21222

merged 3 commits into from Feb 12, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Feb 4, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Ref: #20836 (comment)

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 4, 2020

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented Feb 4, 2020

/rebase

@afc163
Copy link
Member

@afc163 afc163 commented Feb 4, 2020

褰撳墠浠撳簱鍒嗘敮 /rebase 鎵嶄細鐢熸晥銆

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit abfbd98:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Feb 4, 2020

Codecov Report

Merging #21222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21222   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         300      300           
  Lines        7003     7003           
  Branches     1932     1920   -12     
=======================================
  Hits         6832     6832           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7eb4852...abfbd98. Read the comment docs.

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 8, 2020

涓嶅簲璇ョ洿鎺 100%锛岀敤鎴疯缃簡 col 鐨勬椂鍊欏簲璇ユ寜鐓ц缃殑鏉ワ細

鎴睆2020-02-08涓婂崍11 42 19

鎴睆2020-02-08涓婂崍11 42 43

ref: https://preview-21222-ant-design.surge.sh/components/form-cn/#components-form-demo-basic

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented Feb 8, 2020

涓嶅簲璇ョ洿鎺 100%锛岀敤鎴疯缃簡 col 鐨勬椂鍊欏簲璇ユ寜鐓ц缃殑鏉ワ細

鎴睆2020-02-08涓婂崍11 42 19 鎴睆2020-02-08涓婂崍11 42 43

ref: https://preview-21222-ant-design.surge.sh/components/form-cn/#components-form-demo-basic

浠ュ墠鐨勯昏緫灏辨槸 XS 涓 label 鐙崰涓琛岋紝涓嶈繃浠ュ墠鏄氳繃 display:block 鏉ユ帶鍒剁殑

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented Feb 8, 2020

3.0 鐨勭増鏈

image

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 10, 2020

Get 浜嗭紝閭d笅闈㈢殑搴旇涔熸拺婊★細
鎴睆2020-02-10涓婂崍10 32 25

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented Feb 10, 2020

Done.

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 11, 2020

鎴睆2020-02-11涓嬪崍5 16 54

Preview seems no effect.

@zombieJ zombieJ merged commit e01755c into ant-design:master Feb 12, 2020
17 checks passed
@shaodahong shaodahong deleted the fix-less-than-xs-form-label-width branch Feb 12, 2020
orkhan-huseyn pushed a commit to orkhan-huseyn/ant-design that referenced this issue Feb 12, 2020
鈥n#21222)

* fix(Form): label width not correct when screen less than xs

* fix form item control width

* fix css selector priority
yoyo837 pushed a commit that referenced this issue Feb 15, 2020
* add Azerbaijani translation

* fix: rename Azerbaijani translation file

* fix: add az_AZ.txs file into locale/ folder

* fix: linting error on tranling comma

* fix: duplicate locales in locale-provide, a typo

* #21343 - fix (#21344)

* fix(Form): label width not correct when screen less than xs (#21222)

* fix(Form): label width not correct when screen less than xs

* fix form item control width

* fix css selector priority

* fix: separate translation into multiple files for Azerbaijani locale

* fix: wrong import from tr_TR locales into az_AZ

* fix: typo in calendar locale az

* add Azerbaijani translation

* fix: rename Azerbaijani translation file

* fix: add az_AZ.txs file into locale/ folder

* fix: linting error on tranling comma

* fix: duplicate locales in locale-provide, a typo

* add: time picker az_AZ locale

* fix: separate translation into multiple files for Azerbaijani locale

* fix: wrong import from tr_TR locales into az_AZ

* fix: typo in calendar locale az

* update: rc-picker in package.json

Co-authored-by: ElliotAshby <47282526+ElliotAshby@users.noreply.github.com>
Co-authored-by: 楠椾綘鏄皬鐚挭 <darryshaw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants