Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Badge number style #21235

Merged
merged 3 commits into from
Feb 5, 2020
Merged

fix: Badge number style #21235

merged 3 commits into from
Feb 5, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 5, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21172

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge style issue in Typography.
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 5, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b87171:

Sandbox Source
antd reproduction template Configuration
stupefied-butterfly-lpzv1 Issue #21172

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #21235 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21235      +/-   ##
==========================================
- Coverage   97.56%   97.55%   -0.01%     
==========================================
  Files         299      299              
  Lines        6968     6967       -1     
  Branches     1880     1926      +46     
==========================================
- Hits         6798     6797       -1     
  Misses        170      170
Impacted Files Coverage Δ
components/badge/ScrollNumber.tsx 98.66% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f01d8...1b87171. Read the comment docs.

@zombieJ zombieJ merged commit 52a1600 into master Feb 5, 2020
@zombieJ zombieJ deleted the fix-21172 branch February 5, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render issue with <Typography><Comment><Badge></Badge></Comment></Typography>
2 participants