Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bordered prop for controls #21242

Merged
merged 1 commit into from Feb 6, 2020
Merged

feat: Add bordered prop for controls #21242

merged 1 commit into from Feb 6, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 5, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19859

💡 Background and solution

image

image

📝 Changelog

Language Changelog
🇺🇸 English Select/TreeSelect/DatePicker/TimePicker/Cascader support bordered prop.
🇨🇳 Chinese Select/TreeSelect/DatePicker/TimePicker/Cascader 新增 bordered 属性用于指定控件是否有边框。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/cascader/index.en-US.md
View rendered components/cascader/index.zh-CN.md
View rendered components/date-picker/demo/bordered.md
View rendered components/date-picker/index.en-US.md
View rendered components/date-picker/index.zh-CN.md
View rendered components/select/demo/bordered.md
View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md
View rendered components/time-picker/index.en-US.md
View rendered components/time-picker/index.zh-CN.md
View rendered components/tree-select/index.en-US.md
View rendered components/tree-select/index.zh-CN.md

@afc163 afc163 requested a review from zombieJ as a code owner Feb 5, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 5, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02c5715:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Feb 5, 2020

Codecov Report

Merging #21242 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #21242      +/-   ##
===========================================
+ Coverage    97.56%   97.56%   +<.01%     
===========================================
  Files          299      299              
  Lines         6968     6969       +1     
  Branches      1928     1882      -46     
===========================================
+ Hits          6798     6799       +1     
  Misses         170      170
Impacted Files Coverage Δ
components/tree-select/index.tsx 97.72% <ø> (ø) ⬆️
components/select/index.tsx 97.61% <ø> (ø) ⬆️
components/cascader/index.tsx 97.65% <100%> (ø) ⬆️
components/date-picker/generatePicker.tsx 97.05% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a558dd8...02c5715. Read the comment docs.

zombieJ
zombieJ approved these changes Feb 6, 2020
@zombieJ zombieJ merged commit 06ba40e into feature Feb 6, 2020
28 checks passed
@zombieJ zombieJ deleted the feat-bordered branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants