Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typography editable should focus at the end #21268

merged 1 commit into from Feb 7, 2020


Copy link

@afc163 afc163 commented Feb 7, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21261

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography editable should focus at the end of textarea.
🇨🇳 Chinese 修复 Typography editable 时光标没有在输入框末位的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

Copy link

ant-design-bot commented Feb 7, 2020

Copy link

codesandbox-ci bot commented Feb 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9c7ec87:

Sandbox Source
antd reproduction template Configuration

Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #21268 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21268      +/-   ##
+ Coverage   97.55%   97.56%   +<.01%     
  Files         299      299              
  Lines        6967     6970       +3     
  Branches     1926     1879      -47     
+ Hits         6797     6800       +3     
  Misses        170      170
Impacted Files Coverage Δ
components/typography/Editable.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23c550...9c7ec87. Read the comment docs.

@afc163 afc163 merged commit 22908c4 into master Feb 7, 2020
@afc163 afc163 deleted the fix-Typography-focus-position branch February 7, 2020 05:15
afc163 added a commit that referenced this pull request Feb 7, 2020
LukerSpringtree pushed a commit to LukerSpringtree/ant-design that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Typography "editable" focus cursor at the beginning of the text instead of at the end
2 participants