Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form item Input size error with prefix or suffix #21290

Merged
merged 4 commits into from Feb 9, 2020

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Feb 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21288

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复带图标的Input 和 Input.Password 在Form 下不支持通过SizeContext.Consumer 响应正确的尺寸的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input/demo/size.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 8, 2020

@codecov
Copy link

@codecov codecov bot commented Feb 8, 2020

Codecov Report

Merging #21290 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21290      +/-   ##
==========================================
+ Coverage   97.55%   97.55%   +<.01%     
==========================================
  Files         300      300              
  Lines        6996     6999       +3     
  Branches     1928     1882      -46     
==========================================
+ Hits         6825     6828       +3     
  Misses        171      171
Impacted Files Coverage Δ
components/input/Input.tsx 100% <ø> (ø) ⬆️
components/input/Password.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d374cfd...3b8d23b. Read the comment docs.

@yoyo837 yoyo837 changed the title fix: form item Input size error with prefix and suffix fix: form item Input size error with prefix or suffix Feb 8, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0bd32e9:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3b8d23b:

Sandbox Source
antd reproduction template Configuration

@yoyo837
Copy link
Contributor Author

@yoyo837 yoyo837 commented Feb 8, 2020

Any plans for the rc.4 release? 🤔

components/input/style/affix.less Outdated Show resolved Hide resolved
@afc163 afc163 merged commit 02a71d0 into master Feb 9, 2020
27 checks passed
@afc163 afc163 deleted the fix-input-size-with-prefix-and-suffix branch Feb 9, 2020
@yoyo837 yoyo837 mentioned this pull request Feb 9, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants