Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validateFirst in console #21329

Merged
merged 1 commit into from Feb 10, 2020
Merged

fix: validateFirst in console #21329

merged 1 commit into from Feb 10, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 10, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21305

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item validateFirst prevent finial submit.
🇨🇳 Chinese 修复 Form.Item 设置 validateFirst 导致表单无法提交的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 10, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b4ef1a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Feb 10, 2020

Codecov Report

Merging #21329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21329   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         300      300           
  Lines        6999     6999           
  Branches     1929     1918   -11     
=======================================
  Hits         6828     6828           
  Misses        171      171
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4192c1f...6b4ef1a. Read the comment docs.

@zombieJ zombieJ merged commit 68d5e2c into master Feb 10, 2020
28 checks passed
@zombieJ zombieJ deleted the form-validate branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants