Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Affix throws Cannot read property getBoundingClientRect #21350

Merged
merged 1 commit into from Feb 12, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21348

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Affix throws Cannot read property getBoundingClientRect in mobile device.
🇨🇳 Chinese 修复 Affix 在移动设备下抛错 Cannot read property getBoundingClientRect 的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 12, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c1ab52e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #21350 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21350   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         300      300           
  Lines        7003     7003           
  Branches     1884     1932   +48     
=======================================
  Hits         6832     6832           
  Misses        171      171
Impacted Files Coverage Δ
components/affix/index.tsx 99.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01755c...c1ab52e. Read the comment docs.

@afc163 afc163 merged commit f496141 into master Feb 12, 2020
18 checks passed
@afc163 afc163 deleted the fix-affix-bug branch Feb 12, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'getBoundingClientRect' when use Affix
2 participants