fix: Input click should get focus #21413
Merged
+355
−1,759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
afc163
reviewed
Feb 17, 2020
| @@ -273,6 +273,7 @@ class Input extends React.Component<InputProps, InputState> { | |||
| ref={this.saveClearableInput} | |||
| direction={direction} | |||
| focused={focused} | |||
| triggerFocus={this.focus} | |||
There was a problem hiding this comment.
这个是外侧 span 触发 onMouseUp 后，调用 input focus 。它本身不是 onFocus 事件，特地区分开的。
Codecov Report
@@ Coverage Diff @@
## master #21413 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 302 302
Lines 7017 7017
Branches 1924 1936 +12
=======================================
Hits 6865 6865
Misses 152 152
Continue to review full report at Codecov.
|
afc163
approved these changes
Feb 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix #21412
💡 Background and solution
📝 Changelog
prefix/suffixnot get focused.prefix/suffix不会获得焦点的问题。☑️ Self Check before Merge