Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onPanelChange will also trigger by panel value change #21455

Merged
merged 1 commit into from Feb 19, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 19, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21287

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Picker onPanelChange will also trigger when panel value changed.
🇨🇳 Chinese Picker 的 onPanelChange 在面板值变化时也会触发。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered docs/react/migration-v4.en-US.md
View rendered docs/react/migration-v4.zh-CN.md

afc163
afc163 approved these changes Feb 19, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Feb 19, 2020

Changelog 要的句子写完整(比如包含组件名),不然像上周 @chenshuai2144 抄走时会没有具体组件信息。

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 19, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

@codecov codecov bot commented Feb 19, 2020

Codecov Report

Merging #21455 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #21455   +/-   ##
========================================
  Coverage    97.82%   97.82%           
========================================
  Files          302      302           
  Lines         7021     7021           
  Branches      1889     1925   +36     
========================================
  Hits          6868     6868           
  Misses         153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d4e8b...668881d. Read the comment docs.

@zombieJ zombieJ merged commit 5d2bbdd into feature Feb 19, 2020
28 checks passed
@zombieJ zombieJ deleted the onPanelChange branch Feb 19, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 19, 2020
@ycjcl868 ycjcl868 mentioned this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants