Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Form support scrollToFirstError #21462

Merged
merged 10 commits into from Feb 19, 2020
Merged

feat: Form support scrollToFirstError #21462

merged 10 commits into from Feb 19, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 19, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #21442

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Form support scrollToFirstError to simplify submit scroll logic.
🇨🇳 Chinese Form 支持 scrollToFirstError 属性以简化提交表单滚动到错误字段的编码量。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/register.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@zombieJ zombieJ requested a review from afc163 Feb 19, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 19, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd0fa52:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

@codecov codecov bot commented Feb 19, 2020

Codecov Report

Merging #21462 into feature will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #21462      +/-   ##
===========================================
+ Coverage    97.79%    97.8%   +0.01%     
===========================================
  Files          302      302              
  Lines         7026     7026              
  Branches      1891     1891              
===========================================
+ Hits          6871     6872       +1     
+ Misses         155      154       -1
Impacted Files Coverage Δ
components/form/Form.tsx 94.44% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6985b0f...14f5049. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Feb 19, 2020

文档需要补充一下。

afc163
afc163 approved these changes Feb 19, 2020
@zombieJ zombieJ merged commit aa6ccda into feature Feb 19, 2020
6 of 9 checks passed
@zombieJ zombieJ deleted the form-auto-scroll branch Feb 19, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 19, 2020
@ycjcl868 ycjcl868 mentioned this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants