Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input with readOnly should not clearable #21494

Merged
merged 1 commit into from Feb 20, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 20, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21488

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input with readOnly still clearable by allowClear.
🇨🇳 Chinese 修复 Input 在设置 readOnlyallowClear 仍然可以清除的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 20, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

@codecov codecov bot commented Feb 20, 2020

Codecov Report

Merging #21494 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21494      +/-   ##
==========================================
+ Coverage   97.83%   97.83%   +<.01%     
==========================================
  Files         302      302              
  Lines        7018     7024       +6     
  Branches     1923     1894      -29     
==========================================
+ Hits         6866     6872       +6     
  Misses        152      152
Impacted Files Coverage Δ
components/input/ClearableLabeledInput.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1383c...070eff1. Read the comment docs.

@zombieJ zombieJ merged commit 7e649ec into master Feb 20, 2020
27 of 28 checks passed
@zombieJ zombieJ deleted the fix-input-clear branch Feb 20, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 20, 2020
@ycjcl868 ycjcl868 mentioned this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants