fix: Notification can not stack when first init #21531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## master #21531 +/- ##
==========================================
+ Coverage 97.83% 97.83% +<.01%
==========================================
Files 302 302
Lines 7024 7029 +5
Branches 1930 1941 +11
==========================================
+ Hits 6872 6877 +5
Misses 152 152
Continue to review full report at Codecov.
|
1 task
|
解释一下？ |
Merged
afc163
reviewed
Feb 24, 2020
| notificationInstance[cacheKey].destroy(); | ||
| Promise.resolve(notificationInstance[cacheKey]).then(instance => { | ||
| instance.destroy(); | ||
| }); | ||
| delete notificationInstance[cacheKey]; |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
ref #20513
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge