Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lots of Descriptions #21542

Merged
merged 8 commits into from Feb 23, 2020
Merged

fix: Lots of Descriptions #21542

merged 8 commits into from Feb 23, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 23, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20255

💡 Background and solution

计算逻辑有问题,官方的 Demo 计算也是错的。snapshot 也没测对。重写以修复:

  • bordered 时,label 不存在仍然会渲染 label 元素的问题
  • vertical 下且非 bordered 标题也是 td 的问题
  • verticalbordered 布局混乱的问题
  • style 无法作用于 Item 的问题
  • borderth 还会额外获得无用的 -colon className 的问题

以及

  • 使用 rc-util 处理 Fragment 嵌套

📝 Changelog

Language Changelog
🇺🇸 English Fix Descriptions lots of issue.
🇨🇳 Chinese 修复 Descriptions 大量问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 23, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

@codecov codecov bot commented Feb 23, 2020

Codecov Report

Merging #21542 into master will decrease coverage by 0.03%.
The diff coverage is 98.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21542      +/-   ##
==========================================
- Coverage   97.83%    97.8%   -0.04%     
==========================================
  Files         302      304       +2     
  Lines        7029     7009      -20     
  Branches     1930     1931       +1     
==========================================
- Hits         6877     6855      -22     
- Misses        152      154       +2
Impacted Files Coverage Δ
components/descriptions/Row.tsx 100% <100%> (ø)
components/descriptions/Cell.tsx 100% <100%> (ø)
components/descriptions/index.tsx 100% <100%> (+1.07%) ⬆️
components/descriptions/Item.tsx 50% <50%> (ø)
components/breadcrumb/Breadcrumb.tsx 93.54% <0%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7f1da...0655d4f. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Feb 23, 2020

changelog 有点含糊,可以列一列。

afc163
afc163 approved these changes Feb 23, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Feb 23, 2020

居然这么多问题,3.x 里修不?

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Feb 23, 2020

3.x 里需要改成 class,可以修。

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Feb 23, 2020

发现不知道 markdown table 里怎么换行……

@zombieJ zombieJ merged commit 1fad2b0 into master Feb 23, 2020
28 checks passed
@zombieJ zombieJ deleted the refactor-descriptions branch Feb 23, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 23, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Feb 24, 2020

| xx <br /> yy |

@chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Feb 24, 2020

昨天试着用了这个黑科技,fatherdoc 直接挂了

@ycjcl868 ycjcl868 mentioned this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants