-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Lots of Descriptions #21542
fix: Lots of Descriptions #21542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## master #21542 +/- ##
==========================================
- Coverage 97.83% 97.8% -0.04%
==========================================
Files 302 304 +2
Lines 7029 7009 -20
Branches 1930 1931 +1
==========================================
- Hits 6877 6855 -22
- Misses 152 154 +2
Continue to review full report at Codecov.
|
changelog 有点含糊,可以列一列。 |
居然这么多问题,3.x 里修不? |
3.x 里需要改成 class,可以修。 |
发现不知道 markdown table 里怎么换行…… |
|
昨天试着用了这个黑科技,fatherdoc 直接挂了 |
🤔 This is a ...
🔗 Related issue link
fix #20255
💡 Background and solution
计算逻辑有问题,官方的 Demo 计算也是错的。snapshot 也没测对。重写以修复:
bordered
时,label
不存在仍然会渲染 label 元素的问题vertical
下且非bordered
标题也是td
的问题vertical
且bordered
布局混乱的问题style
无法作用于Item
的问题border
下th
还会额外获得无用的-colon
className 的问题以及
rc-util
处理 Fragment 嵌套📝 Changelog
☑️ Self Check before Merge