fix: fix trailColor in line-type progress and add trailColor in docs #21552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afc163
reviewed
Feb 24, 2020
components/progress/demo/line.md
Outdated
| @@ -23,6 +23,7 @@ ReactDOM.render( | |||
| <Progress percent={70} status="exception" /> | |||
| <Progress percent={100} /> | |||
| <Progress percent={50} showInfo={false} /> | |||
| <Progress percent={30} trailColor="#1890ff30" /> | |||
afc163
reviewed
Feb 24, 2020
components/progress/Line.tsx
Outdated
| } = props; | ||
| let backgroundProps; | ||
| let trailStyle; |
AshoneA
force-pushed
the
fix/progress-trail-color
branch
from
f3ebb9c
to
3dbbe50
Compare
Codecov Report
@@ Coverage Diff @@
## master #21552 +/- ##
==========================================
+ Coverage 97.79% 97.79% +<.01%
==========================================
Files 304 304
Lines 7019 7021 +2
Branches 1900 1936 +36
==========================================
+ Hits 6864 6866 +2
Misses 155 155
Continue to review full report at Codecov.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d0295ab:
|
|
加个用例把覆盖率提起来。 |
AshoneA
force-pushed
the
fix/progress-trail-color
branch
from
3dbbe50
to
d0295ab
Compare
|
@AshoneA Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#21550
💡 Background and solution
fix
trailColorprops intype=lineprogress and add trailColor in docs📝 Changelog
trailColornot working whentype=line.trailColor属性在type=line时无效果的问题。☑️ Self Check before Merge
View rendered components/progress/demo/line.md
View rendered components/progress/index.en-US.md
View rendered components/progress/index.zh-CN.md