Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Timeline.Item support label #21560

Merged
merged 6 commits into from Feb 26, 2020
Merged

feat: Timeline.Item support label #21560

merged 6 commits into from Feb 26, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Feb 24, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Resolve #17966

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Timeline.Item 鏀寔 label
馃嚚馃嚦 Chinese Timeline.Item support label

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/timeline/demo/label.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 24, 2020

@shaodahong shaodahong changed the title [WIP] feat: Timeline add label feat: Timeline add label Feb 24, 2020
@shaodahong shaodahong changed the title feat: Timeline add label feat: Timeline.Item support label Feb 24, 2020
@shaodahong shaodahong requested review from afc163 and zombieJ Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #21560 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #21560      +/-   ##
===========================================
+ Coverage    97.84%   97.85%   +<.01%     
===========================================
  Files          304      304              
  Lines         7020     7024       +4     
  Branches      1946     1948       +2     
===========================================
+ Hits          6869     6873       +4     
  Misses         151      151
Impacted Files Coverage 螖
components/timeline/TimelineItem.tsx 91.66% <100%> (+0.75%) 猬嗭笍
components/timeline/Timeline.tsx 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a321b5e...4f01874. Read the comment docs.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f01874:

Sandbox Source
antd reproduction template Configuration

afc163
afc163 approved these changes Feb 26, 2020
@afc163 afc163 merged commit 3269d8c into ant-design:feature Feb 26, 2020
4 of 6 checks passed
@pr-triage pr-triage bot added the PR: merged label Feb 26, 2020
@zombieJ zombieJ mentioned this pull request Feb 27, 2020
10 tasks
@shaodahong shaodahong deleted the timeline-label branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants