fix: fix sortGradient function ignore incorrect percent #21564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
|
AshoneA
force-pushed
the
fix/sort-gradient
branch
from
7942c8c to
3d4551b
Compare
Codecov Report
@@ Coverage Diff @@
## master #21564 +/- ##
==========================================
+ Coverage 97.84% 97.86% +0.01%
==========================================
Files 304 304
Lines 7018 7017 -1
Branches 1945 1945
==========================================
Hits 6867 6867
+ Misses 151 150 -1 Continue to review full report at Codecov.
|
13 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2355db1:
|
afc163
reviewed
Feb 25, 2020
components/progress/Line.tsx
Outdated
| // eslint-disable-next-line no-restricted-syntax | ||
| for (const [key, value] of Object.entries(gradients)) { | ||
| let tempArr: any[] = []; | ||
| Object.entries(gradients).forEach(([key, value]) => { |
There was a problem hiding this comment.
换成了Object.keys，顺便把参数的type改成了StringGradients， 这个type应该更准确。
AshoneA
force-pushed
the
fix/sort-gradient
branch
from
3d4551b to
2355db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix
sortGradientfunction ignore incorrect percent💡 Background and solution
如果传入了错误的参数, 应该忽略掉而不是拿到一个空对象, 添加了新的测试用例并增加了覆盖率
📝 Changelog
strokeColorprops ignore incorrect percentstrokeColor属性忽略错误的百分比参数☑️ Self Check before Merge