Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Breadcrumb 默认使用path作为唯一key #21583

Merged
merged 3 commits into from Feb 27, 2020
Merged

fix: Breadcrumb 默认使用path作为唯一key #21583

merged 3 commits into from Feb 27, 2020

Conversation

douxc
Copy link
Contributor

@douxc douxc commented Feb 25, 2020

Breadcrumb 当前默认优先使用name作为key,但是在多级菜单的时候name很容易出现重复的情况,这就会导致key出现重复,而path是唯一的,所以优先使用path作为key。

同时解决ant-design-pro的这个问题:ant-design/ant-design-pro#3904

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@douxc douxc changed the title Breadcrumb 默认使用path作为唯一key fix:Breadcrumb 默认使用path作为唯一key Feb 25, 2020
@yoyo837 yoyo837 changed the title fix:Breadcrumb 默认使用path作为唯一key fix: Breadcrumb 默认使用path作为唯一key Feb 25, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 25, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 78f54cd:

Sandbox Source
antd reproduction template Configuration

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Feb 26, 2020

更新下snapshot

@douxc
Copy link
Contributor Author

@douxc douxc commented Feb 26, 2020

更新下snapshot

@yoyo837 怎么更新额?

@douxc
Copy link
Contributor Author

@douxc douxc commented Feb 26, 2020

更新下snapshot

@yoyo837 怎么更新额?

看到贡献文档了,我会把这个加上

@codecov
Copy link

@codecov codecov bot commented Feb 27, 2020

Codecov Report

No coverage uploaded for pull request base (master@7838d09). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #21583   +/-   ##
=========================================
  Coverage          ?   97.85%           
=========================================
  Files             ?      305           
  Lines             ?     7008           
  Branches          ?     1930           
=========================================
  Hits              ?     6858           
  Misses            ?      150           
  Partials          ?        0
Impacted Files Coverage Δ
components/radio/radio.tsx 100% <100%> (ø)
components/notification/index.tsx 96.62% <100%> (ø)
components/radio/context.tsx 100% <100%> (ø)
components/radio/group.tsx 94.33% <100%> (ø)
components/radio/radioButton.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7838d09...78f54cd. Read the comment docs.

@afc163 afc163 merged commit 12761e8 into ant-design:master Feb 27, 2020
18 checks passed
@pr-triage pr-triage bot added the PR: merged label Feb 27, 2020
@zombieJ zombieJ mentioned this pull request Feb 27, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants