Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Description key warning #21688

Merged
merged 3 commits into from Feb 28, 2020
Merged

fix: Description key warning #21688

merged 3 commits into from Feb 28, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21686

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Descriptions warning for duplicate key.
🇨🇳 Chinese 修复 Descriptions 报 key 重复的警告信息。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 28, 2020

@@ -69,7 +69,7 @@ function renderCells(
bordered={bordered}
content={children}
/>
</>
</React.Fragment>
Copy link
Member

@afc163 afc163 Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一层是不是可以直接去掉。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1dfb257:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #21688 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21688   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         305      305           
  Lines        6998     6998           
  Branches     1934     1933    -1     
=======================================
  Hits         6850     6850           
  Misses        148      148
Impacted Files Coverage Δ
components/descriptions/index.tsx 100% <ø> (ø) ⬆️
components/descriptions/Row.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb4912...1dfb257. Read the comment docs.

@zombieJ zombieJ merged commit 85a07d1 into master Feb 28, 2020
29 checks passed
@zombieJ zombieJ deleted the fix-desc-warning branch Feb 28, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 28, 2020
myywlc added a commit to myywlc/ant-design that referenced this pull request Feb 28, 2020
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions 提示Sum of column span in a line not match column of Descriptions.
3 participants