Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🔷 Result status type to string & number #21691

Merged
merged 1 commit into from Feb 28, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21592
close #21741

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Result status cannot assigned to string or number type.
🇨🇳 Chinese 修复 Result status 属性不能赋值 string 或者 number 类型的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 28, 2020

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #21691 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21691   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         305      305           
  Lines        6998     6998           
  Branches     1934     1887   -47     
=======================================
  Hits         6850     6850           
  Misses        148      148
Impacted Files Coverage Δ
components/result/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb4912...215521c. Read the comment docs.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 215521c:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 merged commit ed4270b into master Feb 28, 2020
17 checks passed
@afc163 afc163 deleted the fix-result-tsd branch Feb 28, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 28, 2020
afc163 added a commit that referenced this pull request Mar 2, 2020
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
10 tasks
wooldridge added a commit to wooldridge/marklogic-data-hub that referenced this pull request Mar 9, 2020
This antd version fixes the string/number typing issue for the Result component.

Details:
ant-design/ant-design#21592
ant-design/ant-design#21691
marklogic-builder pushed a commit to marklogic/marklogic-data-hub that referenced this pull request Mar 9, 2020
This antd version fixes the string/number typing issue for the Result component.

Details:
ant-design/ant-design#21592
ant-design/ant-design#21691
SameeraPriyathamTadikonda pushed a commit to SameeraPriyathamTadikonda/marklogic-data-hub that referenced this pull request Mar 9, 2020
This antd version fixes the string/number typing issue for the Result component.

Details:
ant-design/ant-design#21592
ant-design/ant-design#21691
SameeraPriyathamTadikonda pushed a commit to marklogic/marklogic-data-hub that referenced this pull request Mar 9, 2020
This antd version fixes the string/number typing issue for the Result component.

Details:
ant-design/ant-design#21592
ant-design/ant-design#21691
LukerSpringtree pushed a commit to LukerSpringtree/ant-design that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants