Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Selection column also support render node #21711

Merged
merged 5 commits into from Feb 29, 2020
Merged

feat: Selection column also support render node #21711

merged 5 commits into from Feb 29, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 29, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #3505

💡 Background and solution

多年前的需求……

📝 Changelog

Language Changelog
🇺🇸 English Table selection column support renderCell.
🇨🇳 Chinese Table 选择列支持 renderCell。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/row-selection-custom-debug.md
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md

@zombieJ zombieJ requested a review from afc163 Feb 29, 2020
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Feb 29, 2020

@afc163 pls help to check the naming style.

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Feb 29, 2020

@afc163
Copy link
Member

@afc163 afc163 commented Feb 29, 2020

多年前的需求……

无法回收的回调函数。

@codecov
Copy link

@codecov codecov bot commented Feb 29, 2020

Codecov Report

Merging #21711 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #21711      +/-   ##
===========================================
+ Coverage    97.88%   97.88%   +<.01%     
===========================================
  Files          305      305              
  Lines         7001     7007       +6     
  Branches      1935     1936       +1     
===========================================
+ Hits          6853     6859       +6     
  Misses         148      148
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 98.87% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c824c...6ef3621. Read the comment docs.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ef3621:

Sandbox Source
antd reproduction template Configuration

afc163
afc163 approved these changes Feb 29, 2020
@zombieJ zombieJ merged commit 6ba42db into feature Feb 29, 2020
29 checks passed
@zombieJ zombieJ deleted the table-row branch Feb 29, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 29, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Feb 29, 2020

Table 选择列支持 renderCell。

从而可以****

changelog 可以写清楚帮助用户理解这个 API 能解决什么问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants