Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table.Column sortOrder is not working in JSX mode #21719

Merged
merged 3 commits into from Mar 1, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 1, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21653

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table.Column sortOrder is not working in JSX mode.
🇨🇳 Chinese 修复 Table.Column sortOrder 在 JSX 模式下无效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 1, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b278e1:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 1, 2020

Codecov Report

Merging #21719 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21719      +/-   ##
==========================================
+ Coverage   97.88%   97.88%   +<.01%     
==========================================
  Files         305      305              
  Lines        7001     7002       +1     
  Branches     1935     1935              
==========================================
+ Hits         6853     6854       +1     
  Misses        148      148
Impacted Files Coverage Δ
components/table/Table.tsx 96.63% <ø> (-0.03%) ⬇️
components/table/hooks/useSorter.tsx 92.59% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f108ee...8b278e1. Read the comment docs.

@zombieJ zombieJ merged commit e868c87 into master Mar 1, 2020
29 checks passed
@zombieJ zombieJ deleted the fix-table-sugar branch Mar 1, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 1, 2020
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants