Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: icons save bundle size without treeShaking #21752

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 2, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21744

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Refactor icons import code to reduce webpack disabled tree shaking bundle size.
🇨🇳 Chinese 重构 icons 导入代码以降低没有开启 tree shaking 的打包尺寸。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 2, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d215b3:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #21752 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21752      +/-   ##
==========================================
+ Coverage   97.88%   97.88%   +<.01%     
==========================================
  Files         305      305              
  Lines        7002     7003       +1     
  Branches     1936     1936              
==========================================
+ Hits         6854     6855       +1     
  Misses        148      148
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100% <ø> (ø) ⬆️
components/message/index.tsx 100% <ø> (ø) ⬆️
components/progress/progress.tsx 100% <ø> (ø) ⬆️
...omponents/table/hooks/useFilter/FilterDropdown.tsx 95.65% <ø> (ø) ⬆️
components/tree/utils/iconUtil.tsx 87.5% <ø> (ø) ⬆️
components/transfer/search.tsx 100% <ø> (ø) ⬆️
components/timeline/Timeline.tsx 100% <ø> (ø) ⬆️
components/tabs/index.tsx 96.87% <ø> (ø) ⬆️
components/notification/index.tsx 96.62% <ø> (ø) ⬆️
components/dropdown/dropdown.tsx 93.18% <ø> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5993fc3...4d215b3. Read the comment docs.

@zombieJ zombieJ merged commit adb323c into master Mar 2, 2020
@zombieJ zombieJ deleted the simply-icons branch March 2, 2020 04:09
@pr-triage pr-triage bot added the PR: merged label Mar 2, 2020
@yoyo837
Copy link
Contributor

yoyo837 commented Mar 2, 2020

还有呀,咋不改完呢

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 2, 2020

噢,那是网站的。

@EastblueOkay
Copy link

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could antd use more specific icon imports internally, rather than importing using destructuring?
4 participants