Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ๐Ÿ“ fix Drawer forceRender doc and tsd #21774

Merged
merged 1 commit into from Mar 2, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 2, 2020

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

close #15287

๐Ÿ’ก Background and solution

  • Documentation
  • TypeScript
  • Test case

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English Fix Drawer forceRender in document and it's TypeScript definite.
๐Ÿ‡จ๐Ÿ‡ณ Chinese ไฟฎๅค Drawer forceRender ็š„ๆ–‡ๆกฃๅ’Œ TypeScript ๅฎšไน‰ใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 2, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8d8385:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #21774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21774   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         305      305           
  Lines        7003     7003           
  Branches     1889     1889           
=======================================
  Hits         6855     6855           
  Misses        148      148
Impacted Files Coverage ฮ”
components/drawer/index.tsx 98.78% <รธ> (รธ) โฌ†๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 920124f...a8d8385. Read the comment docs.

@afc163 afc163 merged commit 9eaaea1 into master Mar 2, 2020
30 checks passed
@afc163 afc163 deleted the fix-drawer-forceRender branch Mar 2, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 2, 2020
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer support forceRender
2 participants