Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TreeSelect.SHOW_* should have constant type #21791

Merged
merged 1 commit into from Mar 3, 2020

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Mar 2, 2020

Signed-off-by: TennyZhuang zty0826@gmail.com

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

While use TreeSelect in typescript, constants TreeSelect.SHOW_* cannot be passed to showCheckedStrategy due to all of them are string type, but type CheckedStrategy = typeof SHOW_ALL | typeof SHOW_PARENT | typeof SHOW_CHILD is required.

📝 Changelog

Language Changelog
🇺🇸 English fix TreeSelect.SHOW_* type
🇨🇳 Chinese 修复了 TreeSelect.SHOW_* 的类型问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang requested a review from zombieJ as a code owner Mar 2, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 2, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6cc30a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #21791 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21791   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         305      305           
  Lines        6999     6999           
  Branches     1931     1930    -1     
=======================================
  Hits         6851     6851           
  Misses        148      148
Impacted Files Coverage Δ
components/tree-select/index.tsx 97.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccca0f3...c6cc30a. Read the comment docs.

@afc163 afc163 merged commit 24133d9 into ant-design:master Mar 3, 2020
16 checks passed
@pr-triage pr-triage bot added the PR: merged label Mar 3, 2020
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants