fix: TreeSelect.SHOW_* should have constant type #21791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TennyZhuang <zty0826@gmail.com>
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6cc30a:
|
Codecov Report
@@ Coverage Diff @@
## master #21791 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 305 305
Lines 6999 6999
Branches 1931 1930 -1
=======================================
Hits 6851 6851
Misses 148 148
Continue to review full report at Codecov.
|
shaodahong
reviewed
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TennyZhuang zty0826@gmail.com
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
While use TreeSelect in typescript, constants
TreeSelect.SHOW_*cannot be passed toshowCheckedStrategydue to all of them are string type, buttype CheckedStrategy = typeof SHOW_ALL | typeof SHOW_PARENT | typeof SHOW_CHILDis required.📝 Changelog
☑️ Self Check before Merge