Skip to content

fix: Fix table column filtered not work#21825

Merged
zombieJ merged 2 commits intomasterfrom
fix-table-filtered
Mar 3, 2020
Merged

fix: Fix table column filtered not work#21825
zombieJ merged 2 commits intomasterfrom
fix-table-filtered

Conversation

@zombieJ
Copy link
Copy Markdown
Member

@zombieJ zombieJ commented Mar 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21797

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table column with filtered not working.
🇨🇳 Chinese 修复 Table column 的 filtered 属性无效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link
Copy Markdown

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Copy Markdown
Contributor

ant-design-bot commented Mar 3, 2020

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Mar 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c0aa2d:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2020

Codecov Report

Merging #21825 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21825      +/-   ##
==========================================
+ Coverage   97.88%   97.88%   +<.01%     
==========================================
  Files         305      305              
  Lines        7003     7005       +2     
  Branches     1932     1887      -45     
==========================================
+ Hits         6855     6857       +2     
  Misses        148      148
Impacted Files Coverage Δ
components/table/hooks/useFilter/index.tsx 100% <ø> (ø) ⬆️
...omponents/table/hooks/useFilter/FilterDropdown.tsx 95.77% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c928952...8c0aa2d. Read the comment docs.

@zombieJ zombieJ merged commit 8fe701b into master Mar 3, 2020
@zombieJ zombieJ deleted the fix-table-filtered branch March 3, 2020 10:18
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
10 tasks
@Superman-wc
Copy link
Copy Markdown

使用4.0.2还是会出现这种情况

@yoyo837
Copy link
Copy Markdown
Contributor

yoyo837 commented Mar 11, 2020

@Superman-wc 来个4.0.2的复现开个issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table: Column's property "filtered" not work

4 participants