Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select with '' string value align issue #21880

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 4, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21871

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select with empty string value align issue.
🇨🇳 Chinese 修复 Select 在空字符串值时的样式对齐问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ
Copy link
Member Author

zombieJ commented Mar 4, 2020

#20538 切换后不需要额外的 line-height,转之做伪类对齐即可。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 4, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97ea37d:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7cd1e98:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #21880 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21880   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         305      305           
  Lines        6999     6999           
  Branches     1929     1928    -1     
=======================================
  Hits         6857     6857           
  Misses        142      142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa3eb3...7cd1e98. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select component has a css error when its value set to empty string
2 participants