Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table expandIconColumnIndex with rowSelect #21915

Merged
merged 3 commits into from Mar 5, 2020
Merged

fix: Table expandIconColumnIndex with rowSelect #21915

merged 3 commits into from Mar 5, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 5, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21781

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table expandIconColumnIndex display order with rowSelection.
🇨🇳 Chinese 修复 Table expandIconColumnIndexrowSelection 公用时的展示顺序问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 5, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e798d5:

Sandbox Source
antd reproduction template Configuration
gallant-grass-xt0mo Issue #21781

@zombieJ zombieJ merged commit 36c05dd into master Mar 5, 2020
28 checks passed
@codecov
Copy link

@codecov codecov bot commented Mar 5, 2020

Codecov Report

Merging #21915 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21915      +/-   ##
==========================================
+ Coverage   97.96%   97.96%   +<.01%     
==========================================
  Files         305      305              
  Lines        7013     7015       +2     
  Branches     1932     1933       +1     
==========================================
+ Hits         6870     6872       +2     
  Misses        143      143
Impacted Files Coverage Δ
components/table/Table.tsx 96.69% <100%> (+0.05%) ⬆️
components/table/hooks/useSelection.tsx 98.81% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe0e3d...1e798d5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants