Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Form.useForm return same instance now #21927

Merged
merged 2 commits into from Mar 6, 2020
Merged

chore: Form.useForm return same instance now #21927

merged 2 commits into from Mar 6, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 6, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21924

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Form.useForm return same instance in render now.
🇨🇳 Chinese Form.useForm 现在在 render 中将返回相同的实例。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 6, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2af282c:

Sandbox Source
antd reproduction template Configuration
cranky-moser-rlvpb Issue #21924

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #21927 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21927      +/-   ##
==========================================
+ Coverage   97.96%   97.96%   +<.01%     
==========================================
  Files         305      305              
  Lines        7015     7017       +2     
  Branches     1888     1933      +45     
==========================================
+ Hits         6872     6874       +2     
  Misses        143      143
Impacted Files Coverage Δ
components/form/util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8876d5...2af282c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form.useForm 能否返回同一个实例
2 participants