Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tree/TreeSelect/Select support virtual prop to disable virtual scroll #21955

Merged
merged 2 commits into from Mar 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 6, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #21722

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tree/TreeSelect/Select support virtual prop to disable virtual scroll
🇨🇳 Chinese Tree/TreeSelect/Select 支持 virtual 属性以关闭虚拟滚动。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md
View rendered components/tree-select/index.en-US.md
View rendered components/tree-select/index.zh-CN.md
View rendered components/tree/index.en-US.md
View rendered components/tree/index.zh-CN.md

@zombieJ zombieJ requested a review from afc163 Mar 6, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 6, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f578c56:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 6, 2020

Codecov Report

Merging #21955 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #21955   +/-   ##
========================================
  Coverage    97.97%   97.97%           
========================================
  Files          305      305           
  Lines         7046     7046           
  Branches      1947     1902   -45     
========================================
  Hits          6903     6903           
  Misses         143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8170b...f578c56. Read the comment docs.

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Mar 7, 2020

回头到 master 里看看怎么省 Bundle size。

afc163
afc163 approved these changes Mar 7, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Mar 7, 2020

bundle size 超了?

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Mar 7, 2020

对,关闭的 virtual 的功能让 gzip 多了 0.26 KB。

@zombieJ zombieJ merged commit 8f09465 into feature Mar 7, 2020
28 of 30 checks passed
@zombieJ zombieJ deleted the virtual branch Mar 7, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Mar 7, 2020

这不科学,master 是 296kb。

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Mar 7, 2020

feature branch 还有其他的更新,这三个组件是最后的稻草 😄

@afc163
Copy link
Member

@afc163 afc163 commented Mar 10, 2020

feature 分支上 rc-visual-list 版本没升。

@afc163 afc163 mentioned this pull request Mar 10, 2020
14 tasks
@harunurhan
Copy link

@harunurhan harunurhan commented Mar 11, 2020

when do you plan to release this? @zombieJ @afc163

@afc163
Copy link
Member

@afc163 afc163 commented Mar 12, 2020

发布时注意要补上 #22093 的 changelog。

#22093

@YufeeXing
Copy link

@YufeeXing YufeeXing commented Nov 10, 2020

select默认virtual的情况下,但选择列表数量较多(来自后端接口)的时候,编辑状态下,就是select在Form(也是antd 组件)里并且field被赋值后,点击select弹出的选择列表有一定概率是空白,显示不了选择项,滑动鼠标滚轮恢复。

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Nov 10, 2020

@YufeeXing 给个重现看看?

@YufeeXing
Copy link

@YufeeXing YufeeXing commented Nov 17, 2020

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Nov 18, 2020

@YufeeXing 能给个 codesandbox 吗? https://codesandbox.io/

@YufeeXing
Copy link

@YufeeXing YufeeXing commented Nov 18, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants