Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 TextArea[autoSize] don't scroll bottom in Firefox #22014

Merged
merged 1 commit into from Mar 9, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21870

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix TextArea autoSize don't scroll bottom in Firefox.
🇨🇳 Chinese 修复 TextArea autoSize 时在 Firefox 下不会自动滚动到底的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the title fix TextArea[autoSize] don't scroll bottom in Firefox fix: TextArea[autoSize] don't scroll bottom in Firefox Mar 9, 2020
@afc163 afc163 changed the title fix: TextArea[autoSize] don't scroll bottom in Firefox fix: 🐛 TextArea[autoSize] don't scroll bottom in Firefox Mar 9, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 9, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c8d15cb:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #21870

@codecov
Copy link

@codecov codecov bot commented Mar 9, 2020

Codecov Report

Merging #22014 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22014      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         306      306              
  Lines        7032     7039       +7     
  Branches     1891     1892       +1     
==========================================
+ Hits         6887     6893       +6     
- Misses        145      146       +1
Impacted Files Coverage Δ
components/input/ResizableTextArea.tsx 93.54% <100%> (+0.82%) ⬆️
components/breadcrumb/Breadcrumb.tsx 91.93% <0%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125c154...c8d15cb. Read the comment docs.

@afc163 afc163 merged commit 8dd8a19 into master Mar 9, 2020
30 checks passed
@afc163 afc163 deleted the fix-textarea-firefox branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants