Skip to content

fix: 🐛 TextArea[autoSize] don't scroll bottom in Firefox#22014

Merged
afc163 merged 1 commit into
masterfrom
fix-textarea-firefox
Mar 9, 2020
Merged

fix: 🐛 TextArea[autoSize] don't scroll bottom in Firefox#22014
afc163 merged 1 commit into
masterfrom
fix-textarea-firefox

Conversation

@afc163

@afc163 afc163 commented Mar 9, 2020

Copy link
Copy Markdown
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21870

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix TextArea autoSize don't scroll bottom in Firefox.
🇨🇳 Chinese 修复 TextArea autoSize 时在 Firefox 下不会自动滚动到底的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@tests-checker tests-checker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the title fix TextArea[autoSize] don't scroll bottom in Firefox fix: TextArea[autoSize] don't scroll bottom in Firefox Mar 9, 2020
@afc163 afc163 changed the title fix: TextArea[autoSize] don't scroll bottom in Firefox fix: 🐛 TextArea[autoSize] don't scroll bottom in Firefox Mar 9, 2020
@ant-design-bot

ant-design-bot commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

@codesandbox-ci

codesandbox-ci Bot commented Mar 9, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c8d15cb:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #21870

@codecov

codecov Bot commented Mar 9, 2020

Copy link
Copy Markdown

Codecov Report

Merging #22014 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22014      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         306      306              
  Lines        7032     7039       +7     
  Branches     1891     1892       +1     
==========================================
+ Hits         6887     6893       +6     
- Misses        145      146       +1
Impacted Files Coverage Δ
components/input/ResizableTextArea.tsx 93.54% <100%> (+0.82%) ⬆️
components/breadcrumb/Breadcrumb.tsx 91.93% <0%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125c154...c8d15cb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firefox - Autosized textarea doesn't scroll as you type

2 participants