Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only menu icon #22021

Merged
merged 1 commit into from
Mar 9, 2020
Merged

fix: Only menu icon #22021

merged 1 commit into from
Mar 9, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22008

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu horizontal Item with nest Icon miss margin style.
🇨🇳 Chinese 修复 Menu 水平 Item 使用嵌套结构 Icon 会丢失 margin 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ merged commit 94eefa3 into master Mar 9, 2020
@zombieJ zombieJ deleted the fix-only-menu branch March 9, 2020 08:54
@afc163
Copy link
Member

afc163 commented Mar 9, 2020

#21984

这里还会有问题,需要额外修复一下。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38bb2f7:

Sandbox Source
antd reproduction template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The <Icon> in <Menu.Item> with <Link> wrapped has margin-right: 0
2 participants