-
-
Notifications
You must be signed in to change notification settings - Fork 49.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support render props for <Popover/> and <Popconfirm/> #22034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Mine's a realllllly old version 😅, rebasing... |
65fc6b3
to
d08b5e6
Compare
d08b5e6
to
1a67712
Compare
Codecov Report
@@ Coverage Diff @@
## feature #22034 +/- ##
===========================================
- Coverage 97.93% 97.92% -0.02%
===========================================
Files 306 307 +1
Lines 7032 7040 +8
Branches 1891 1938 +47
===========================================
+ Hits 6887 6894 +7
- Misses 145 146 +1
Continue to review full report at Codecov.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c0363d:
|
1a67712
to
3c0363d
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 717d19c:
|
bc20fc2
to
717d19c
Compare
@afc163 Thanks for the merge! 🙂 |
🤔 This is a ...
🔗 Related issue link
#21935
💡 Background and solution
Problem:
Current
<Popover/>
and<Popconfirm/>
doesn't support render props.Solution:
Add support for render props for
<Popover/>
and<Popconfirm/>
📝 Changelog
☑️ Self Check before Merge
View rendered components/popover/index.en-US.md
View rendered components/popover/index.zh-CN.md