Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ๐Ÿ”จ simplify Popconfirm and Popover dom structure #22052

Merged
merged 1 commit into from Mar 10, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 10, 2020

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

๐Ÿ’ก Background and solution

simplify Popconfirm and Popover dom structure

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English Simplify Popconfirm and Popover dom structure
๐Ÿ‡จ๐Ÿ‡ณ Chinese ็ฎ€ๅŒ– Popconfirm ๅ’Œ Popover ็š„ dom ็ป“ๆž„ใ€‚

โ˜‘๏ธ Self Check before Merge

โš ๏ธ Please check all items below before review. โš ๏ธ

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 force-pushed the update-popover-popconfirm-dom branch from cb350c9 to 8614c81 Compare Mar 10, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 10, 2020

@afc163 afc163 changed the base branch from master to feature Mar 10, 2020
@afc163 afc163 force-pushed the update-popover-popconfirm-dom branch from 8614c81 to 63394be Compare Mar 10, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 10, 2020

Codecov Report

Merging #22052 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22052   +/-   ##
========================================
  Coverage    97.97%   97.97%           
========================================
  Files          307      307           
  Lines         7076     7076           
  Branches      1943     1954   +11     
========================================
  Hits          6933     6933           
  Misses         143      143
Impacted Files Coverage ฮ”
components/popover/index.tsx 100% <รธ> (รธ) โฌ†๏ธ
components/popconfirm/index.tsx 100% <100%> (รธ) โฌ†๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 3bbd63a...a0ee45b. Read the comment docs.

@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 10, 2020

Approve needed.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a0ee45b:

Sandbox Source
antd reproduction template Configuration

@shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 10, 2020

ๅŒ…็š„ไฝ“็งฏๆ€Žไนˆๅ˜ๅคงไบ†

@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 10, 2020

feature ๅˆ†ๆ”ฏ๏ผŒไธ€็‚นไธ€็‚น่นญ่ถ…ไบ†ใ€‚ๆˆ‘็œ‹็œ‹ๅ“ช้‡Œ่ƒฝ็œไธ€็‚นไธ‹ๆฅใ€‚

@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 10, 2020

/rebase

@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 10, 2020

็œไธ‹ๆฅไบ†๏ผš#22055

@github-actions github-actions bot force-pushed the update-popover-popconfirm-dom branch from 63394be to a0ee45b Compare Mar 10, 2020
@afc163 afc163 merged commit cff8c08 into feature Mar 10, 2020
20 checks passed
@afc163 afc163 deleted the update-popover-popconfirm-dom branch Mar 10, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants