Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: ๐Ÿ’„ New table filter menu buttons #22072

Merged
merged 4 commits into from Mar 10, 2020
Merged

style: ๐Ÿ’„ New table filter menu buttons #22072

merged 4 commits into from Mar 10, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 10, 2020 •
edited

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ”— Related issue link

close #14149

๐Ÿ’ก Background and solution

  • Redesign filter menu buttons.
old new
image image
  • fix Dropdown edge padding
broken fixed
image image

๐Ÿ“ Changelog

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English - Redesign Table filter menu buttons.
- fix Dropdown edge padding style.
๐Ÿ‡จ๐Ÿ‡ณ Chinese - ไผ˜ๅŒ– Table ็ญ›้€‰่œๅ•ๆŒ‰้’ฎ็š„ๆ ทๅผใ€‚
- ไฟฎๅค Dropdown ไบŒ็บง่œๅ•็š„ไธŠไธ‹่พน่ทใ€‚

โ˜‘๏ธ Self Check before Merge

โš ๏ธ Please check all items below before review. โš ๏ธ

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/breadcrumb/index.en-US.md
View rendered components/breadcrumb/index.zh-CN.md
View rendered components/carousel/index.en-US.md
View rendered components/carousel/index.zh-CN.md
View rendered components/form/demo/nest-messages.md
View rendered components/popconfirm/index.en-US.md
View rendered components/popconfirm/index.zh-CN.md
View rendered components/popover/index.en-US.md
View rendered components/popover/index.zh-CN.md

@afc163 afc163 requested a review from zombieJ as a code owner Mar 10, 2020
tests-checker[bot]
tests-checker bot suggested changes Mar 10, 2020
View changes
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the base branch from master to feature Mar 10, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 10, 2020 •
edited

@afc163 afc163 changed the title style: New table filter menu buttons style: ๐Ÿ’„ New table filter menu buttons Mar 10, 2020
@afc163 afc163 changed the title style: ๐Ÿ’„ New table filter menu buttons [WIP] style: ๐Ÿ’„ New table filter menu buttons Mar 10, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a68db2d:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 10, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c5c1b6d:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 changed the title [WIP] style: ๐Ÿ’„ New table filter menu buttons style: ๐Ÿ’„ New table filter menu buttons Mar 10, 2020
@afc163 afc163 force-pushed the new-table-filter-menu-buttons branch from aa8756f to 130e23d Compare Mar 10, 2020
@afc163 afc163 force-pushed the new-table-filter-menu-buttons branch from 130e23d to ebd31cd Compare Mar 10, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 10, 2020 •
edited

Codecov Report

Merging #22072 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22072   +/-   ##
========================================
  Coverage    97.97%   97.97%           
========================================
  Files          307      307           
  Lines         7076     7076           
  Branches      1953     1953           
========================================
  Hits          6933     6933           
  Misses         143      143
Impacted Files Coverage ฮ”
...omponents/table/hooks/useFilter/FilterDropdown.tsx 95.77% <100%> (รธ) โฌ†๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update cff8c08...c5c1b6d. Read the comment docs.

afc163
afc163 reviewed Mar 10, 2020
View changes
components/table/__tests__/Table.filter.test.js
.at(0)
.simulate('mouseEnter');
jest.runAllTimers();
dropdownWrapper = getDropdownWrapper(wrapper);
Copy link
Member Author

@afc163 afc163 Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

้‡ๆ–ฐๅ–ไธ€ไธ‹ๅฐฑ่กŒไบ†ใ€‚

@afc163 afc163 merged commit 145f727 into feature Mar 10, 2020
29 checks passed
@afc163 afc163 deleted the new-table-filter-menu-buttons branch Mar 10, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 10, 2020
@afc163 afc163 mentioned this pull request Mar 13, 2020
Closed
@afc163 afc163 mentioned this pull request Mar 18, 2020
Closed
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker

@zombieJ zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afc163 @ant-design-bot @zombieJ