Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 💄 New table filter menu buttons #22072

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 10, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #14149

💡 Background and solution

  • Redesign filter menu buttons.
old new
image image
  • fix Dropdown edge padding
broken fixed
image image

📝 Changelog

Language Changelog
🇺🇸 English - Redesign Table filter menu buttons.
- fix Dropdown edge padding style.
🇨🇳 Chinese - 优化 Table 筛选菜单按钮的样式。
- 修复 Dropdown 二级菜单的上下边距。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/breadcrumb/index.en-US.md
View rendered components/breadcrumb/index.zh-CN.md
View rendered components/carousel/index.en-US.md
View rendered components/carousel/index.zh-CN.md
View rendered components/form/demo/nest-messages.md
View rendered components/popconfirm/index.en-US.md
View rendered components/popconfirm/index.zh-CN.md
View rendered components/popover/index.en-US.md
View rendered components/popover/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the base branch from master to feature March 10, 2020 10:10
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 10, 2020

@afc163 afc163 changed the title style: New table filter menu buttons style: 💄 New table filter menu buttons Mar 10, 2020
@afc163 afc163 changed the title style: 💄 New table filter menu buttons [WIP] style: 💄 New table filter menu buttons Mar 10, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a68db2d:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c5c1b6d:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 changed the title [WIP] style: 💄 New table filter menu buttons style: 💄 New table filter menu buttons Mar 10, 2020
@afc163 afc163 force-pushed the new-table-filter-menu-buttons branch from aa8756f to 130e23d Compare March 10, 2020 10:39
@afc163 afc163 force-pushed the new-table-filter-menu-buttons branch from 130e23d to ebd31cd Compare March 10, 2020 12:43
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #22072 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22072   +/-   ##
========================================
  Coverage    97.97%   97.97%           
========================================
  Files          307      307           
  Lines         7076     7076           
  Branches      1953     1953           
========================================
  Hits          6933     6933           
  Misses         143      143
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 95.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff8c08...c5c1b6d. Read the comment docs.

.at(0)
.simulate('mouseEnter');
jest.runAllTimers();
dropdownWrapper = getDropdownWrapper(wrapper);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重新取一下就行了。

@afc163 afc163 merged commit 145f727 into feature Mar 10, 2020
@afc163 afc163 deleted the new-table-filter-menu-buttons branch March 10, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants