Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table filter menu reset not working #22079

Merged
merged 2 commits into from Mar 10, 2020
Merged

fix: Table filter menu reset not working #22079

merged 2 commits into from Mar 10, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 10, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Resolve #22075

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix Table filter menu reset not working
馃嚚馃嚦 Chinese 淇 Table filter 鑿滃崟閲嶇疆澶辨晥

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 10, 2020

@afc163 afc163 requested a review from zombieJ Mar 10, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 707dc6a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 10, 2020

Codecov Report

Merging #22079 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22079      +/-   ##
==========================================
+ Coverage   97.96%   97.96%   +<.01%     
==========================================
  Files         306      306              
  Lines        7038     7039       +1     
  Branches     1937     1937              
==========================================
+ Hits         6895     6896       +1     
  Misses        143      143
Impacted Files Coverage 螖
...omponents/table/hooks/useFilter/FilterDropdown.tsx 95.83% <100%> (+0.05%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3670ca7...707dc6a. Read the comment docs.

@zombieJ zombieJ merged commit 924f1cf into ant-design:master Mar 10, 2020
19 checks passed
@shaodahong shaodahong deleted the fix-table-filter-reset branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants