Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't non-null assertion #22096

Merged
merged 1 commit into from Mar 11, 2020
Merged

fix: Don't non-null assertion #22096

merged 1 commit into from Mar 11, 2020

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Mar 11, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22094

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复 Table 筛选功能抛出 Cannot read property 'map' of undefined 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 11, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b56414:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 11, 2020

Codecov Report

Merging #22096 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22096      +/-   ##
==========================================
+ Coverage   97.96%   97.96%   +<.01%     
==========================================
  Files         306      306              
  Lines        7041     7042       +1     
  Branches     1928     1939      +11     
==========================================
+ Hits         6898     6899       +1     
  Misses        143      143
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 95.89% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e726f...1b56414. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Mar 11, 2020

Changelog 按用户视角写一下。

@yoyo837
Copy link
Contributor Author

@yoyo837 yoyo837 commented Mar 11, 2020

Changelog 按用户视角写一下。

改了下

@afc163
Copy link
Member

@afc163 afc163 commented Mar 11, 2020

修复table筛选功能,对filters的使用可能未赋值的运行时错误

修复 Table 筛选功能抛出 Cannot read property 'map' of undefined 的问题。

@yoyo837
Copy link
Contributor Author

@yoyo837 yoyo837 commented Mar 11, 2020

修复table筛选功能,对filters的使用可能未赋值的运行时错误

修复 Table 筛选功能抛出 Cannot read property 'map' of undefined 的问题。

👌

@yoyo837 yoyo837 changed the title fix: remove non-null assertion fix: Don't non-null assertion Mar 11, 2020
@afc163 afc163 merged commit 5d9d1ef into master Mar 11, 2020
30 checks passed
@afc163 afc163 deleted the not-non-null-assertion branch Mar 11, 2020
@collinbarrett
Copy link

@collinbarrett collinbarrett commented Mar 11, 2020

Wow, that was fast. Looking forward to testing this fix in the next release. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants