Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix vertical handle position #22135

Merged
merged 3 commits into from Mar 13, 2020
Merged

Conversation

hullis
Copy link
Contributor

@hullis hullis commented Mar 11, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#22128

同时还解决了 slider handle 和 mark 未对齐的问题

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix handles' position when slider is vertical
🇨🇳 Chinese 修复垂直情况下 slider handle 的位置

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@hullis
Copy link
Contributor Author

@hullis hullis commented Mar 11, 2020

Before:

截屏2020-03-1200 23 23

After:

截屏2020-03-1200 52 16

Clicking:

屏幕录制2020-03-1200 53 38

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 11, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1100892:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 11, 2020

Codecov Report

Merging #22135 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22135   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7042     7042           
  Branches     1893     1938   +45     
=======================================
  Hits         6899     6899           
  Misses        143      143
Impacted Files Coverage Δ
components/slider/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b118909...1100892. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Mar 12, 2020

  1. <Slider vertical reverse /> still has problem: https://codesandbox.io/s/antd-reproduction-template-ht3em
  2. We can change vertical Slider Tooltip placement to right.

@afc163
Copy link
Member

@afc163 afc163 commented Mar 12, 2020

similar issue: #19682

@afc163
Copy link
Member

@afc163 afc163 commented Mar 13, 2020

rebase master

@hullis hullis force-pushed the slider-vertical-transform branch from bd4e974 to 1100892 Compare Mar 13, 2020
@afc163 afc163 merged commit a6c207d into ant-design:master Mar 13, 2020
19 checks passed
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Mar 16, 2020

3.x 的也顺手改一下?

@hullis
Copy link
Contributor Author

@hullis hullis commented Mar 16, 2020

3.x 的也顺手改一下?

没问题。但是这个修复需要在 rc-slider 里面进行,要再发布一个 8.x 的版本吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants