Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add breadcrumb clear #22159

Merged
merged 4 commits into from Mar 12, 2020
Merged

style: add breadcrumb clear #22159

merged 4 commits into from Mar 12, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Mar 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Added Breadcrumb RTL mode to clear floats
🇨🇳 Chinese 增加 Breadcrumb RTL 模式下清除浮动

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

display: block;
clear: both;
content: '';
}
Copy link
Member

@afc163 afc163 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个覆盖太广了,单独修改 breadcrumb 吧。

Copy link
Contributor

@yoyo837 yoyo837 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我刚想说 😄

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 12, 2020

@codecov
Copy link

@codecov codecov bot commented Mar 12, 2020

Codecov Report

Merging #22159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22159   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7042     7042           
  Branches     1938     1893   -45     
=======================================
  Hits         6899     6899           
  Misses        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12420a9...e41d0e6. Read the comment docs.

display: block;
clear: both;
content: '';
}
Copy link
Member

@afc163 afc163 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有个 .clearfix 的 mixin 可以用。

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 29af5b9:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e41d0e6:

Sandbox Source
antd reproduction template Configuration

@@ -5,6 +5,7 @@

.@{breadcrumb-prefix-cls} {
.reset-component;
.clearfix;
Copy link
Member

@afc163 afc163 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

给 rtl 模式单独加就可以了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants