Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add checkbox grop RTL #22186

Merged
merged 6 commits into from Mar 13, 2020
Merged

style: add checkbox grop RTL #22186

merged 6 commits into from Mar 13, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Mar 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

  • Checkbox.Group 的每个 相隔 8px,在 RTL 模式下,样式异常。
  • 优化 Demo 中 Button 的显示

📝 Changelog

Language Changelog
🇺🇸 English Optimize the Checkbox.Group style in RTL mode
🇨🇳 Chinese 优化 Checkbox.Group 在 RTL 模式下样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/checkbox/demo/controller.md

}
}
&-item + &-item {
margin-left: 0;
.@{checkbox-prefix-cls}-group-rtl & {
margin-left: 8px;
}
Copy link
Member

@afc163 afc163 Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉给每个组件单独创建一个 rtl.less,这样相关代码收在一起比较好改。

Copy link
Member Author

@xrkffgg xrkffgg Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是啊,我先用这个改一下试试

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 13, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ef042c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 13, 2020

Codecov Report

Merging #22186 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22186   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7042     7042           
  Branches     1893     1938   +45     
=======================================
  Hits         6899     6899           
  Misses        143      143
Impacted Files Coverage Δ
components/checkbox/Group.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b118909...5ef042c. Read the comment docs.

@xrkffgg xrkffgg requested a review from afc163 Mar 13, 2020
afc163
afc163 approved these changes Mar 13, 2020
@afc163 afc163 merged commit b032344 into master Mar 13, 2020
26 of 27 checks passed
@afc163 afc163 deleted the fix-checkbox-rtl branch Mar 13, 2020
@xrkffgg xrkffgg changed the title style: add checkout grop RTL style: add checkbox grop RTL Mar 16, 2020
@xrkffgg xrkffgg mentioned this pull request Mar 16, 2020
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants