-
-
Notifications
You must be signed in to change notification settings - Fork 49.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Menu.Item Tooltip could be hidden by title prop #22202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4b576f6:
|
Codecov Report
@@ Coverage Diff @@
## feature #22202 +/- ##
===========================================
+ Coverage 97.98% 97.98% +<.01%
===========================================
Files 358 358
Lines 7142 7146 +4
Branches 1957 1949 -8
===========================================
+ Hits 6998 7002 +4
Misses 144 144
Continue to review full report at Codecov.
|
🤔 This is a ...
🔗 Related issue link
close #11252
💡 Background and solution
This will allow us using
title
to hide default Tooltip on menu item.📝 Changelog
title
prop.title={null}
来禁用。☑️ Self Check before Merge