Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Menu.Item Tooltip could be hidden by title prop #22202

Merged
merged 2 commits into from Mar 13, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #11252

💡 Background and solution

This will allow us using title to hide default Tooltip on menu item.

        <Menu.Item key="menu4" title={null}>
          item
        </Menu.Item>
        <Menu.Item key="menu5" title="">
          item
        </Menu.Item>

📝 Changelog

Language Changelog
🇺🇸 English Menu.Item Tooltip could be hidden by falsy title prop.
🇨🇳 Chinese Menu.Item 上的 Tooltip 现在可以使用 title={null} 来禁用。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 13, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b576f6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #22202 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #22202      +/-   ##
===========================================
+ Coverage    97.98%   97.98%   +<.01%     
===========================================
  Files          358      358              
  Lines         7142     7146       +4     
  Branches      1957     1949       -8     
===========================================
+ Hits          6998     7002       +4     
  Misses         144      144
Impacted Files Coverage Δ
components/menu/MenuItem.tsx 95.65% <100%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf3578...4b576f6. Read the comment docs.

@afc163 afc163 merged commit e9862c5 into feature Mar 13, 2020
29 checks passed
@afc163 afc163 deleted the feat-menu-item-falsy-item branch Mar 13, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
@illeb illeb mentioned this pull request Jul 6, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants