Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Card support tabProps #22207

Merged
merged 3 commits into from Mar 14, 2020
Merged

feat: Card support tabProps #22207

merged 3 commits into from Mar 14, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 14, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Resolve #10223

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Card support tabProps
馃嚚馃嚦 Chinese Card 鏀寔 tabProps

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/card/index.en-US.md
View rendered components/card/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 14, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c27b2e1:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 14, 2020

Codecov Report

Merging #22207 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22207   +/-   ##
========================================
  Coverage    97.98%   97.98%           
========================================
  Files          358      358           
  Lines         7146     7147    +1     
  Branches      1914     1960   +46     
========================================
+ Hits          7002     7003    +1     
  Misses         144      144           
Impacted Files Coverage 螖
components/card/index.tsx 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e9862c5...c27b2e1. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Mar 14, 2020

鏉ヤ釜鐢ㄤ緥

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented Mar 14, 2020

Done.

ztplz
ztplz approved these changes Mar 14, 2020
@afc163 afc163 merged commit 869f93d into ant-design:feature Mar 14, 2020
19 checks passed
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants