Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adjust Radio.Group logic that value is undefined should be uncontrolled mode. #22245

Merged
merged 2 commits into from Mar 16, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 16, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22209

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Adjust Radio.Group logic that value is undefined should be uncontrolled mode.
🇨🇳 Chinese 调整 Radio.Group 逻辑,value 为 undefined 时为非受控状态。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@zombieJ zombieJ changed the title Adjust radio group refactor: Adjust Radio.Group logic that value is undefined should be uncontrolled mode. Mar 16, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 16, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4ce11c2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 16, 2020

Codecov Report

Merging #22245 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22245      +/-   ##
==========================================
+ Coverage   97.96%   97.96%   +<.01%     
==========================================
  Files         306      306              
  Lines        7042     7043       +1     
  Branches     1938     1938              
==========================================
+ Hits         6899     6900       +1     
  Misses        143      143
Impacted Files Coverage Δ
components/radio/group.tsx 94.44% <90%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e9b7c...4ce11c2. Read the comment docs.

@zombieJ zombieJ merged commit c86c3cf into master Mar 16, 2020
29 of 30 checks passed
@zombieJ zombieJ deleted the adjust-radio-group branch Mar 16, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Mar 16, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants