Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 💄 fix Select dropdown menu vertical padding #22251

merged 1 commit into from Mar 16, 2020


Copy link

@afc163 afc163 commented Mar 16, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

broken fixed
image image

📝 Changelog

Language Changelog
🇺🇸 English Fix Select dropdown menu vertical padding.
🇨🇳 Chinese 修复 Select 下拉菜单的上下 padding。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@@ -7,6 +7,7 @@

@select-prefix-cls: ~'@{ant-prefix}-select';
@select-height-without-border: @input-height-base - 2 * @border-width-base;
@select-dropdown-edge-child-vertical-padding: @dropdown-edge-child-vertical-padding;
Copy link
Member Author

@afc163 afc163 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 3.x 中有的变量也补上。

Copy link

@ant-design-bot ant-design-bot commented Mar 16, 2020

Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5795b88:

Sandbox Source
antd reproduction template Configuration

Copy link

@codecov codecov bot commented Mar 16, 2020

Codecov Report

Merging #22251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22251   +/-   ##
  Coverage   97.96%   97.96%           
  Files         306      306           
  Lines        7043     7043           
  Branches     1938     1893   -45     
  Hits         6900     6900           
  Misses        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec4656...5795b88. Read the comment docs.

@afc163 afc163 merged commit 442a4e4 into master Mar 16, 2020
30 checks passed
@afc163 afc163 deleted the fix-select-style branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants