Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table onFilter only should work #22317

Merged
merged 2 commits into from Mar 17, 2020
Merged

fix: Table onFilter only should work #22317

merged 2 commits into from Mar 17, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21277

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table filter no working when only set onFilter.
🇨🇳 Chinese 修复 Table 在只设置 onFilter 时过滤无效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 17, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa9aa03:

Sandbox Source
antd reproduction template Configuration

@zombieJ zombieJ merged commit f4d3dc4 into master Mar 17, 2020
22 of 26 checks passed
@zombieJ zombieJ deleted the table-filter branch Mar 17, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8ff3452:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 17, 2020

Codecov Report

Merging #22317 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22317      +/-   ##
==========================================
+ Coverage   97.92%   97.96%   +0.04%     
==========================================
  Files         306      306              
  Lines        7043     7043              
  Branches     1928     1893      -35     
==========================================
+ Hits         6897     6900       +3     
+ Misses        146      143       -3
Impacted Files Coverage Δ
components/table/hooks/useFilter/index.tsx 100% <100%> (ø) ⬆️
components/carousel/index.tsx 100% <0%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69ff7e...8ff3452. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants