fix: Upload onChange immutable #22322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a235a7:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e5b0fc5:
|
Codecov Report
@@ Coverage Diff @@
## master #22322 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 306 306
Lines 7043 7043
Branches 1939 1938 -1
=======================================
Hits 6900 6900
Misses 143 143
Continue to review full report at Codecov.
|
afc163
reviewed
Mar 18, 2020
| this.cachedSelectedKeys = newSelectedKeys; | ||
| newEvent.selectedNodes = [event.node.props.data]; | ||
| newEvent.selectedNodes = convertDirectoryKeysToNodes(treeData, newSelectedKeys); |
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
resolve #22281
💡 Background and solution
📝 Changelog
onChangereturnfileListis immutable data to avoid render issue.onChange返回参数fileList为不可变数据以解决渲染问题。☑️ Self Check before Merge