Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table row expand icon show error in ipad #22334

Merged

Conversation

BugHiding
Copy link
Contributor

@BugHiding BugHiding commented Mar 18, 2020

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

close #22289

💡 需求背景和解决方案

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文 Fix table expand row icon show error in ipad.
🇨🇳 中文 修复 Table 展开行图标在 ipad 上显示错误的问题。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 18, 2020

@yoyo837 yoyo837 changed the title Table row expand icon show error in ipad fix: Table row expand icon show error in ipad Mar 18, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69c5c27:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 18, 2020

Codecov Report

Merging #22334 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22334   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7044     7044           
  Branches     1893     1939   +46     
=======================================
  Hits         6901     6901           
  Misses        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a2567...69c5c27. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Mar 18, 2020

image

@BugHiding
Copy link
Contributor Author

@BugHiding BugHiding commented Mar 18, 2020

@afc163 已更正,第一次提交代码,兴奋~感谢~

@afc163
Copy link
Member

@afc163 afc163 commented Mar 18, 2020

表格展开行图标样式添加 padding: 0; 解决其在ipad上的显示错误

直接描述解决了什么问题就行了。

@BugHiding
Copy link
Contributor Author

@BugHiding BugHiding commented Mar 18, 2020

修复 Table 展开行图标在 ipad 上显示错误的问题。

这样可以么。 @afc163

@afc163 afc163 merged commit 38c72f2 into ant-design:master Mar 18, 2020
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants