Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimization of noStyle message #22410

Merged
merged 1 commit into from Mar 19, 2020
Merged

refactor: optimization of noStyle message #22410

merged 1 commit into from Mar 19, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 19, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22288

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimization Form.Item with multiple noStyle children Form.Item message collection performance.
🇨🇳 Chinese 优化 Form.Item 有多个 noStyle 子 Form.Item 时信息收集性能。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 19, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f96d69c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 19, 2020

Codecov Report

Merging #22410 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22410      +/-   ##
==========================================
+ Coverage   98.08%   98.08%   +<.01%     
==========================================
  Files         306      306              
  Lines        7046     7061      +15     
  Branches     1928     1938      +10     
==========================================
+ Hits         6911     6926      +15     
  Misses        135      135
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.1% <100%> (-0.04%) ⬇️
components/form/util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289d66a...f96d69c. Read the comment docs.

@zombieJ zombieJ merged commit 9e3ddb2 into master Mar 19, 2020
30 of 32 checks passed
@zombieJ zombieJ deleted the opt-form branch Mar 19, 2020
function setFrameValue(updater: Updater<ValueType>) {
if (frameRef.current === null) {
batchRef.current = [];
frameRef.current = requestAnimationFrame(() => {
Copy link
Member

@afc163 afc163 Mar 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site build 挂了是有原因的。

Copy link
Member

@afc163 afc163 Mar 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants