Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Col without span prop should keep default #22455

Merged
merged 1 commit into from Mar 22, 2020
Merged

fix: Col without span prop should keep default #22455

merged 1 commit into from Mar 22, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 21, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#21907 (comment)

💡 Background and solution

之前改的有点问题,应该和 3.x Flex 模式保持一致,4.0.3 版本加了会造成 breaking change

后续我研究下加上 jest-image-snapshot ,把 Grid 和 Form 的 image snapshot 搞下

📝 Changelog

Language Changelog
🇺🇸 English Fix Grid broken style using Col without span.
🇨🇳 Chinese 修复 Grid 下使用不带 span 的 Col 时样式错乱的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 21, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 515dded:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 merged commit d7e8fa2 into ant-design:master Mar 22, 2020
16 of 18 checks passed
@shaodahong shaodahong deleted the default-col branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants