Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gapDegree=0 in Dashboard progress is now working #22462

Merged
merged 3 commits into from Mar 22, 2020
Merged

fix: gapDegree=0 in Dashboard progress is now working #22462

merged 3 commits into from Mar 22, 2020

Conversation

thisrabbit
Copy link
Contributor

@thisrabbit thisrabbit commented Mar 21, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#22347

💡 Background and solution

Problem: API defination about Progress is partial wrong (the default value), and also gapDegree=0 in type="dashboard" won't make effect.
Fix: by polishing the API doc and updating code about gapDeg.

📝 Changelog

Language Changelog
🇺🇸 English Fix the issue that Dashboard Progress won't allow gapDeg to be 0
🇨🇳 Chinese 修复仪表盘状进度条传入 gapDeg 为 0 时仍然有缺口的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/progress/demo/segment.md
View rendered components/progress/index.en-US.md
View rendered components/progress/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 21, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a201ce5:

Sandbox Source
antd reproduction template Configuration

@thisrabbit
Copy link
Contributor Author

@thisrabbit thisrabbit commented Mar 21, 2020

Also, the default value in progrss.jsx has changed from 0 to undefined.

@afc163
Copy link
Member

@afc163 afc163 commented Mar 21, 2020

来个用例吧。

@thisrabbit
Copy link
Contributor Author

@thisrabbit thisrabbit commented Mar 21, 2020

来个用例吧。

OK, I will work on it~

@thisrabbit
Copy link
Contributor Author

@thisrabbit thisrabbit commented Mar 21, 2020

来个用例吧。

OK, I will work on it~

Done. Also a question, it's weird that gapDegree only support up to 295 rather than 359 (or 360), I think it might be some issue within rc-progress. By far I have corrected the default value in API doc, and I will explore this issue in future.

@thisrabbit thisrabbit changed the title Fix: gapDegree=0 in Dashboard progress is now working fix: gapDegree=0 in Dashboard progress is now working Mar 21, 2020
@afc163 afc163 merged commit 0519111 into ant-design:master Mar 22, 2020
16 of 18 checks passed
@thisrabbit thisrabbit deleted the fix-progress-api branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants